Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements. #114

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Small improvements. #114

merged 2 commits into from
Jan 21, 2025

Conversation

tbrezot
Copy link
Contributor

@tbrezot tbrezot commented Jan 21, 2025 •
edited
Loading

Notable changes:

  • remove a clone when instantiating a Redis memory;
  • strengthen the concurrency test by looping N times in each concurrent worker
  • remove a redundant condition in the g-write script
  • remove some unnecessary bounds in the generic tests
  • remove redundant documentation (please, refrain your LLM)
  • remove the bench feature

@tbrezot tbrezot requested a review from HatemMn January 21, 2025 12:40
@tbrezot tbrezot mentioned this pull request Jan 21, 2025
Merged
5 tasks
HatemMn
HatemMn reviewed Jan 21, 2025
View reviewed changes
Copy link
Contributor

@HatemMn HatemMn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the PR summary basically says everything

We just need to find a solution for the conn manager before merging to avoid killing the server

src/memory/redis_store.rs Show resolved Hide resolved
@HatemMn HatemMn merged commit ce6da6e into feat/findex-server-v7 Jan 21, 2025
8 checks passed
@HatemMn HatemMn deleted the tbz/review branch January 21, 2025 14:36
@HatemMn HatemMn restored the tbz/review branch January 21, 2025 14:36
@Manuthor Manuthor deleted the tbz/review branch January 27, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HatemMn HatemMn HatemMn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbrezot @HatemMn