Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review #96

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Review #96

merged 4 commits into from
Dec 3, 2024

Conversation

tbrezot
Copy link
Contributor

@tbrezot tbrezot commented Dec 2, 2024

Remove useless pragmas, dep. features and clones in redis_mem.rs.

  • rename to remove the mention to "store" everywhere.

@tbrezot tbrezot requested review from Manuthor and HatemMn and removed request for Manuthor December 3, 2024 08:49
HatemMn
HatemMn approved these changes Dec 3, 2024
View reviewed changes
Copy link

@HatemMn HatemMn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ok

@HatemMn HatemMn merged commit 2cded1e into feat/prepare_findex_server_v7 Dec 3, 2024
7 checks passed
@Manuthor Manuthor deleted the tbz/review branch December 3, 2024 10:23
@tbrezot tbrezot restored the tbz/review branch December 11, 2024 14:16
@tbrezot tbrezot deleted the tbz/review branch January 15, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HatemMn HatemMn HatemMn approved these changes

@Manuthor Manuthor Awaiting requested review from Manuthor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbrezot @HatemMn