Merge pull request #344 from Countly/current-view-name

Added current view name in event segmentation
Countly · Sep 25, 2024 · c33eb3a · c33eb3a
2 parents 2d9eac4 + 27747d7
commit c33eb3a
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 8 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## 24.7.3
+* Added current view names to event segmentation based on the `enablePreviousNameRecording` (Experimental!)
+
 ## 24.7.2
 * Automatic view pause/resumes are changed with stop/start for better data consistency.
 * Added the config interface 'experimental' to group experimental features.

diff --git a/Countly-PL.podspec b/Countly-PL.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name = 'Countly-PL'
-  s.version = '24.7.2'
+  s.version = '24.7.3'
   s.license = { :type => 'MIT', :file => 'LICENSE' }
   s.summary  = 'Countly is an innovative, real-time, open source mobile analytics platform.'
   s.homepage = 'https://github.com/Countly/countly-sdk-ios'

diff --git a/Countly.m b/Countly.m
@@ -915,6 +915,7 @@ - (void)recordEvent:(NSString *)key segmentation:(NSDictionary *)segmentation co
         if(CountlyViewTrackingInternal.sharedInstance.enablePreviousNameRecording) {
             filteredSegmentations[kCountlyPreviousEventName] = previousEventName ?: @"";
             previousEventName = key;
+            filteredSegmentations[kCountlyCurrentView] = CountlyViewTrackingInternal.sharedInstance.currentViewName ?: @"";
         }
     }
     event.key = key;

diff --git a/Countly.podspec b/Countly.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |s|
   s.name = 'Countly'
-  s.version = '24.7.2'
+  s.version = '24.7.3'
   s.license = { :type => 'MIT', :file => 'LICENSE' }
   s.summary  = 'Countly is an innovative, real-time, open source mobile analytics platform.'
   s.homepage = 'https://github.com/Countly/countly-sdk-ios'

diff --git a/Countly.xcodeproj/project.pbxproj b/Countly.xcodeproj/project.pbxproj
@@ -726,7 +726,7 @@
 					"@loader_path/Frameworks",
 				);
 				MACOSX_DEPLOYMENT_TARGET = 10.14;
-				MARKETING_VERSION = 24.7.2;
+				MARKETING_VERSION = 24.7.3;
 				PRODUCT_BUNDLE_IDENTIFIER = ly.count.CountlyiOSSDK;
 				PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
 				PROVISIONING_PROFILE_SPECIFIER = "";
@@ -758,7 +758,7 @@
 					"@loader_path/Frameworks",
 				);
 				MACOSX_DEPLOYMENT_TARGET = 10.14;
-				MARKETING_VERSION = 24.7.2;
+				MARKETING_VERSION = 24.7.3;
 				PRODUCT_BUNDLE_IDENTIFIER = ly.count.CountlyiOSSDK;
 				PRODUCT_NAME = "$(TARGET_NAME:c99extidentifier)";
 				PROVISIONING_PROFILE_SPECIFIER = "";

diff --git a/CountlyCommon.m b/CountlyCommon.m
@@ -29,7 +29,7 @@ @interface CountlyCommon ()
 #endif
 @end
 
-NSString* const kCountlySDKVersion = @"24.7.2";
+NSString* const kCountlySDKVersion = @"24.7.3";
 NSString* const kCountlySDKName = @"objc-native-ios";
 
 NSString* const kCountlyErrorDomain = @"ly.count.ErrorDomain";

diff --git a/CountlyViewTrackingInternal.h b/CountlyViewTrackingInternal.h
@@ -8,7 +8,6 @@
 
 extern NSString* const kCountlyReservedEventView;
 
-//TODO: Need discussion for its usage and then we decide to keep it or remove it
 extern NSString* const kCountlyCurrentView;
 extern NSString* const kCountlyPreviousView;
 extern NSString* const kCountlyPreviousEventName;
@@ -19,7 +18,6 @@ extern NSString* const kCountlyPreviousEventName;
 @property (nonatomic) NSString* previousViewID;
 
 @property (nonatomic) BOOL enablePreviousNameRecording;
-//TODO: Need discussion for its usage and then we decide to keep it or remove it
 @property (nonatomic) NSString* currentViewName;
 @property (nonatomic) NSString* previousViewName;
 

diff --git a/CountlyViewTrackingInternal.m b/CountlyViewTrackingInternal.m
@@ -17,7 +17,6 @@ @interface CountlyViewTrackingInternal ()
 
 NSString* const kCountlyReservedEventView = @"[CLY]_view";
 
-//TODO: Need discussion for its usage and then we decide to keep it or remove it
 NSString* const kCountlyCurrentView = @"cly_cvn";
 NSString* const kCountlyPreviousView = @"cly_pvn";