Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression de code inutilisé et renommage ad hoc #142

Merged
merged 7 commits into from
May 5, 2021
Merged

Suppression de code inutilisé et renommage ad hoc #142

merged 7 commits into from
May 5, 2021

Conversation

Floby
Copy link
Collaborator

@Floby Floby commented May 2, 2021

Nettoyage préalable pendant que je cherchais à m'y retrouver pour me lancer sur #122

@Floby Floby force-pushed the cleanup branch 3 times, most recently from aea67b0 to 6ed8ba5 Compare May 2, 2021 22:22
@fcamblor
Copy link
Collaborator

fcamblor commented May 3, 2021

@Floby merci pour ces commits très atomiques c'est un bonheur à revoir ;-)

Rien ne bloque, j'attends juste ton feedback sur startsWith / includes

@Floby
Copy link
Collaborator Author

Floby commented May 4, 2021

@fcamblor @Luwangel c'est up avec polyfills !
Un des chunk legacy depasse le budget (500ko) mais je pense que c'est lié à #138 plutôt.

@fcamblor
Copy link
Collaborator

fcamblor commented May 4, 2021

Parfait le vitejs-legacy... ça m'embête pas plus que ça de faire télécharger 500k supplémentaires aux vieux browsers, tant pis pour eux :)

Il y a un merge un peu relou à faire sur le vmd-commune-selector.component.ts avant de pouvoir merge la PR

@Floby
Copy link
Collaborator Author

Floby commented May 5, 2021

rebased !

@Floby Floby merged commit 3c62b3b into dev May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants