add enumerate #19
Merged
add enumerate #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratmice
commented
Dec 1, 2023
|
Looks great! Sorry for the delay on the other PR, will try getting to it today |
|
Don't worry about delays at all, I'm just happy to help. I went ahead and rebased out the interim change. I'm happy to merge as-is, but will leave it for a day or so in case anybody can think of anything else? |
|
Went ahead and merged this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a quick implementation of enumerate. The tests are I guess a bit wonky, but I wanted to test that we match the behavior for some of the
std::iter::Enumerate's non-fused corner cases.