Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/team creation #49

Merged
merged 20 commits into from
Jan 16, 2024
Merged

Feature/team creation #49

merged 20 commits into from
Jan 16, 2024

Conversation

aj-bhatia
Copy link
Contributor

@aj-bhatia aj-bhatia commented Jan 9, 2024

Scope

Team Creation for hackers Github Dev Board

Implementation

Created firebase functions for all team components, as well as creating team user interface

How to Test

Testing Hacker Dashboard:

  • create/login with multiple hacker accounts
  • create a team using one of them
  • invite other user to the team
  • login to the other hacker account
  • accept or deny invite
  • use other functionalities built in to dashboard

Testing Admin Dashboard:

  • create/login with admin accounts
  • navigate to teams dashboard
  • remove members from times
  • delete or lock in teams

Copy link

github-actions bot commented Jan 9, 2024

Visit the preview URL for this PR (updated for commit 7275ca5):

https://cruzhacks-2024-developme-d58c3--pr49-feature-team-crea-gsx4omzz.web.app

(expires Tue, 23 Jan 2024 22:14:37 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c133166642cf00772f1bd63e2c20bba5d0c0a74e

Copy link
Member

@zacktraczyk zacktraczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UI looks great but doesn't seem to function with given database schema. users/{email}/user_items/team doc does not exist by default which causes an error in team creation and invites.

Also you will need an accompanying backend PR bc one of your queries requires an Index. I can do this for you if it is easier.

In admin portal /teams page:

FirebaseError: The query requires a COLLECTION_GROUP_ASC index for collection teams and field teamName.

Copy link
Member

@zacktraczyk zacktraczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome !

@zacktraczyk zacktraczyk merged commit 9385248 into development Jan 16, 2024
1 of 2 checks passed
@zacktraczyk zacktraczyk deleted the feature/team-creation branch January 16, 2024 23:15
@zacktraczyk zacktraczyk restored the feature/team-creation branch January 17, 2024 00:25
@zacktraczyk zacktraczyk deleted the feature/team-creation branch January 17, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants