Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added and Corrected the Initial Files of the Zod #185

Merged
merged 6 commits into from
May 27, 2024

Conversation

ujjwalagrawal-1
Copy link
Contributor

#133 Solved
Please review the Files

Corrected this #153 Pull Request

Some of the SS are ->
Screenshot 2024-05-17 173048
Screenshot 2024-05-17 173016
Screenshot 2024-05-17 172743

and also Corrected
#152

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @ujjwalagrawal-1! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@CDCNaman
Copy link
Collaborator

@ujjwalagrawal-1
Thanks for your Contribution, this is exactly what is required with a very small minor bug.
You have imposed the same Registration Schema Validation middleware on both sign up and sign in route
That is why it is asking for username as well on sign-in as well
image

@CDCNaman
Copy link
Collaborator

@ujjwalagrawal-1 and sorry I am asking for changes 2nd time, but its required.
So Please let me know will you make changes otherwise we can raise one more issue for the remaining changes.

@thecuriousteam
Copy link
Contributor

@ujjwalagrawal-1 brothe please can you make those changes?

@thecuriousteam
Copy link
Contributor

We have given level3 can you update it brother?

@ujjwalagrawal-1
Copy link
Contributor Author

@thecuriousteam OK I Will do it .

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @ujjwalagrawal-1

@ujjwalagrawal-1
Copy link
Contributor Author

@thecuriousteam @CDCNaman I have Corrected it now and now it is not Showing any type of error please review it Once.

and thanks for showing me the error.

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @ujjwalagrawal-1

@ujjwalagrawal-1
Copy link
Contributor Author

@thecuriousteam is There any Update ??

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @ujjwalagrawal-1

1 similar comment
Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @ujjwalagrawal-1

@ujjwalagrawal-1
Copy link
Contributor Author

@thecuriousteam @CDCNaman Please see this PR also .

@CDCNaman
Copy link
Collaborator

@ujjwalagrawal-1 Definitely I will check today and sorry for delay.

@CDCNaman
Copy link
Collaborator

@ujjwalagrawal-1 I have approved your PR soon @thecuriousteam will merge this

@ujjwalagrawal-1
Copy link
Contributor Author

Thanks @CDCNaman

Copy link

Hi there! This issue is still open. We are looking forward to your response.
Assignees: @ujjwalagrawal-1

@ujjwalagrawal-1
Copy link
Contributor Author

@CDCNaman is there any Problem in merging this ??

@thecuriousteam thecuriousteam merged commit 697d429 into Curious-Ecosystem:main May 27, 2024
@ujjwalagrawal-1
Copy link
Contributor Author

@CDCNaman Thanks for the Merge .

@ujjwalagrawal-1
Copy link
Contributor Author

ujjwalagrawal-1 commented May 30, 2024

@CDCNaman I have Solved 2 issues in this PR then Also in points table i am getting only one label points can you tell me the issue.

#152 is resolved with this PR
Please add level 2 Label that you have added to this issue beacuse GSSOC is not reading that .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Invalid username Access Bug : No Zod Validation in the Authentication
3 participants