Skip to content

Commit

Permalink
libcamera: properly advertise lack of scene mode
Browse files Browse the repository at this point in the history
Otherwise Focal with errorneously show all available scene modes

Change-Id: Id2987c6f3a01a331485bb76d879a6178b1c22bf6
  • Loading branch information
pawitp authored and bbelos committed Aug 2, 2013
1 parent 231e0c5 commit 1189ddf
Showing 1 changed file with 3 additions and 24 deletions.
27 changes: 3 additions & 24 deletions libcamera/SecCameraHWInterface.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -259,30 +259,9 @@ void CameraHardwareSec::initDefaultParameters(int cameraId)
CameraParameters::FLASH_MODE_OFF);
#endif

parameterString = CameraParameters::SCENE_MODE_AUTO;
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_PORTRAIT);
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_LANDSCAPE);
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_NIGHT);
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_BEACH);
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_SNOW);
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_SUNSET);
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_FIREWORKS);
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_SPORTS);
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_PARTY);
parameterString.append(",");
parameterString.append(CameraParameters::SCENE_MODE_CANDLELIGHT);
// TODO: CE147 doesn't understand scene mode
//p.set(CameraParameters::KEY_SUPPORTED_SCENE_MODES,
// parameterString.string());
// CE147 doesn't understand scene mode
p.set(CameraParameters::KEY_SUPPORTED_SCENE_MODES,
CameraParameters::SCENE_MODE_AUTO);
p.set(CameraParameters::KEY_SCENE_MODE,
CameraParameters::SCENE_MODE_AUTO);

Expand Down

0 comments on commit 1189ddf

Please sign in to comment.