Improves dotnet dependency tree with case insensitive match (#1586)

Signed-off-by: Prabhu Subramanian <[email protected]>

lib/cli/index.js

@@ -5986,7 +5986,11 @@ export function trimComponents(components) {
   const keyCache = {};
   const filteredComponents = [];
   for (const comp of components) {
-    const key = comp.purl || comp["bom-ref"] || comp.name + comp.version;
+    const key = (
+      comp.purl ||
+      comp["bom-ref"] ||
+      comp.name + comp.version
+    ).toLowerCase();
     if (!keyCache[key]) {
       keyCache[key] = comp;
     } else {

lib/helpers/utils.js

@@ -9431,17 +9431,43 @@ export function parseCsProjAssetsData(csProjData, assetsJsonFile) {
           continue;
         }
         const targetNameVersion = `${nameOperatorVersion.name}/${nameOperatorVersion.version}`;
-
-        // skip if the dep is not in the targets for whatever reason
+        let nameToUse = nameOperatorVersion.name;
+        // Due to the difference in casing, we might arrive this case where a simple lookup doesn't succeed.
+        // Instead of skipping, let's work harder to find a match.
         if (!csProjData.targets[frameworkTarget][targetNameVersion]) {
-          continue;
+          let matchFound = false;
+          for (const fkeys of Object.keys(
+            csProjData.targets[frameworkTarget],
+          )) {
+            const tmpParts = fkeys.split("/");
+            const tname = tmpParts[0];
+            const tversion = tmpParts[1];
+            if (
+              tname.toLowerCase() === nameOperatorVersion.name.toLowerCase() &&
+              tversion === nameOperatorVersion.version
+            ) {
+              nameToUse = tname;
+              matchFound = true;
+              break;
+            }
+          }
+          if (!matchFound) {
+            if (DEBUG_MODE) {
+              console.log(
+                "Unable to match",
+                dependencyName,
+                "with a target name. The dependency tree will be imprecise.",
+              );
+            }
+            continue;
+          }
         }
 
         const dpurl = decodeURIComponent(
           new PackageURL(
             "nuget",
             "",
-            nameOperatorVersion.name,
+            nameToUse,
             nameOperatorVersion.version,
             null,
             null,

lib/helpers/validator.js

@@ -281,6 +281,9 @@ export function validateProps(bomJson) {
   let isWorkspaceMode = false;
   if (bomJson?.components) {
     for (const comp of bomJson.components) {
+      if (!["library", "framework"].includes(comp.type)) {
+        continue;
+      }
       if (!comp.properties) {
         warningsList.push(`${comp["bom-ref"]} lacks properties.`);
       } else {
@@ -296,7 +299,6 @@ export function validateProps(bomJson) {
           }
         }
         if (
-          ["library", "framework"].includes(comp.type) &&
           isWorkspaceMode &&
           !workspacePropFound &&
           comp?.scope !== "optional"