-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix typo #659
fix typo #659
Conversation
Signed-off-by: iamahens <[email protected]>
please review @prabhu |
@iamahens Could you sign the commit by following the instructions below? https://github.com/CycloneDX/cdxgen/pull/659/checks?check_run_id=17936934826 |
Signed-off-by: Sneha Saxena <[email protected]>
README.md
Outdated
@@ -2,7 +2,7 @@ | |||
|
|||
![cdxgen logo](cdxgen.png) | |||
|
|||
cdxgen is a cli tool, library, [REPL](./ADVANCED.md), and server to create a valid and compliant [CycloneDX][cyclonedx-homepage] Software Bill of Materials (SBOM) containing an aggregate of all project dependencies for c/c++, node.js, php, python, ruby, rust, java, .Net, dart, haskell, elixir, and Go projects in JSON format. CycloneDX 1.5 is a lightweight SBOM specification that is easily created, human and machine-readable, and simple to parse. | |||
cdxgen is a CLI tool, library, [REPL](./ADVANCED.md), and server to create a valid and compliant [CycloneDX][cyclonedx-homepage] Software Bill of Materials (SBOM) containing an aggregate of all project dependencies for C/C++, node.js, php, python, ruby, rust, java, .Net, Dart, haskell, elixir, and Go projects in JSON format. CycloneDX 1.5 is a lightweight SBOM specification that is easily created, human and machine-readable, and simple to parse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iamahens This seems to be missing capitalization for all languages and other edits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@prabhu yes!
@prabhu If everything looks good to you, could you kindly merge this PR? Much appreciated! |
@iamahens, it doesn't look complete. Are you planning to capitalize all languages? |
Signed-off-by: iamahens <[email protected]>
Signed-off-by: iamahens <[email protected]>
@prabhu |
| Python | pyproject.toml, setup.py, requirements.txt [2], Pipfile.lock, poetry.lock, pdm.lock, bdist_wheel, .whl, .egg-info | Yes using the automatic pip install/freeze. When disabled, only with Pipfile.lock and poetry.lock | Yes | | ||
| Go | binary, go.mod, go.sum, Gopkg.lock | Yes except binary | Yes | | ||
| Ruby | Gemfile.lock, gemspec | Only for Gemfile.lock | | | ||
| Uust | binary, Cargo.toml, Cargo.lock | Only for Cargo.lock | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops. Didn't see this typo.
This pull request addresses and corrects several grammatical errors found throughout the codebase.
The changes include fixing typos, punctuation, and ensuring proper sentence structure for improved readability and clarity.