Improved fetching license information for npm packages #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacek Puchta <[email protected]>
puchta
force-pushed
the
issue-671-fix-fetching-license-information-for-npm-packages
branch
3 times, most recently
from
7718861 to
3938f30
Compare
Signed-off-by: Jacek Puchta <[email protected]>
puchta
force-pushed
the
issue-671-fix-fetching-license-information-for-npm-packages
branch
from
3938f30 to
cc4a2b3
Compare
Signed-off-by: Jacek Puchta <[email protected]>
prabhu
approved these changes
Oct 26, 2023
| @@ -3095,6 +3098,9 @@ export const getRepoLicense = async function (repoUrl, repoMetadata) { | |||
| if (!repoUrl) { | |||
| repoUrl = toGitHubUrl(repoMetadata); | |||
| } | |||
| if (repoUrl.startsWith("git://") && repoUrl.endsWith(".git")) { | |||
There was a problem hiding this comment.
I think this logic is true only for a handful of providers such as github. There might be other places that do this, so fine for now.
Could we split this into two conditions so that we also handle the case where the URL starts with git+https and doesn't end with .git?
Eg: git+https
https://github.com/CycloneDX/cdxgen/blob/master/package.json#L52
Below is also valid since don't think npm performs any validation.
git+https://github.com/CycloneDX/cdxgen
|
Thank you! |
puchta
deleted the
issue-671-fix-fetching-license-information-for-npm-packages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.