-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/transitive require #678
Closed
Closed
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
e63501f
1. Add analyze transitive dep in required components (js) 2. Add para…
avgkoster 96dfad6
fix lint
avgkoster 56488ae
fix lint#2
avgkoster 325529e
fix lint #4
avgkoster 8069a79
last fix lint
avgkoster 78fd6c5
add git-url-parse
3a599e7
fix server
aa9299a
Revert "fix server"
avgkoster 7f00537
Update utils.test.js, add new dep
avgkoster 11b5e0f
Removed gir-url parse pkg, remove parsedUrl in console.log
avgkoster 0abeddc
Del unused dep, fix lint
avgkoster 0ef02cf
1. Add analyze transitive dep in required components (js) 2. Add para…
avgkoster 802de1d
fix lint
avgkoster 631744d
fix lint#2
avgkoster 744985b
fix lint #4
avgkoster a8bdb50
last fix lint
avgkoster 72428f4
add git-url-parse
d42e8a9
fix server
2581787
Revert "fix server"
avgkoster eda2560
Update utils.test.js, add new dep
avgkoster c326fb1
Removed gir-url parse pkg, remove parsedUrl in console.log
avgkoster 8344f61
Del unused dep, fix lint
avgkoster ce3e8dc
Merge branch 'feature/transitive_require' of https://github.com/avgko…
avgkoster 7a8a65a
fix deps, lint
avgkoster File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we there is a way to avoid this nested loop. For large boms with 1000s of components this might be slow. wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To shorten the execution time, I think it is possible to make a condition under which, if we do not find direct imports in required dependencies, then only then try to look for sub-dependencies.
But I also think that displaying in occurrences all imports (even those where there were direct ones), and not just direct ones, can be useful.