Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved detection for standalone jar files by using pom.properties file if available #724

Merged
merged 6 commits into from
Nov 19, 2023
Merged

Improved detection for standalone jar files by using pom.properties file if available #724

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0445b31
parse pom properties files for stanadalone jars
Nikemare Nov 17, 2023
932b6f4
Formatted utils.js
Nikemare Nov 17, 2023
7d5dc0f
Fixed console.log
Nikemare Nov 17, 2023
30eeaab
Better confidence info in extractJarArchive
Nikemare Nov 18, 2023
1b0d4c6
Added repotest for standalone jar files
Nikemare Nov 19, 2023
c7d633c
Fix repotest for standalone jar files
Nikemare Nov 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/repotests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ jobs:
curl --output-dir standalone-jar-files -LO https://repo1.maven.org/maven2/com/fasterxml/jackson/core/jackson-core/2.16.0/jackson-core-2.16.0.jar
curl --output-dir standalone-jar-files -LO https://repo1.maven.org/maven2/junit/junit/4.13.2/junit-4.13.2.jar
curl --output-dir standalone-jar-files -LO https://repo1.maven.org/maven2/wsdl4j/wsdl4j/1.6.3/wsdl4j-1.6.3.jar
FETCH_LICENSE=true bin/cdxgen.js -p -o bomresults/bom-standalone-jar-files.json --validate
FETCH_LICENSE=true bin/cdxgen.js -p standalone-jar-files -o bomresults/bom-standalone-jar-files.json --validate
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted!

shell: bash
- name: repotests 1.4
run: |
Expand Down
Loading