-
-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor repotests #729
Refactor repotests #729
Conversation
Signed-off-by: Nikemare <[email protected]>
Signed-off-by: Nikemare <[email protected]>
Signed-off-by: Nikemare <[email protected]>
bin/cdxgen.js -p -r -t java repotests/shiftleft-java-example -o bomresults/bom-java.json --generate-key-and-sign --spec-version 1.4 | ||
SBOM_SIGN_ALGORITHM=RS512 SBOM_SIGN_PRIVATE_KEY=bomresults/private.key SBOM_SIGN_PUBLIC_KEY=bomresults/public.key bin/cdxgen.js -p -r -t github repotests/shiftleft-java-example -o bomresults/bom-github.json --spec-version 1.4 | ||
FETCH_LICENSE=false bin/cdxgen.js -p -r -t js repotests/shiftleft-ts-example -o bomresults/bom-ts.json --validate --spec-version 1.4 | ||
FETCH_LICENSE=1 bin/cdxgen.js -p -r -t js repotests/shiftleft-ts-example --required-only -o bomresults/bom-ts.json --validate --spec-version 1.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The idea was that some users were using 0 and 1 so we had tests to ensure those continued to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, restored some FETCH_LICENSE with 0 and 1 instead of true / false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good idea! Thank you so much!
Signed-off-by: Nikemare <[email protected]>
@Nikemare looks like we are running out of disk space which is a known github issue. https://github.com/CycloneDX/cdxgen/actions/runs/6937263539/job/18870984681 could you add the trim ci agent to the job? https://github.com/CycloneDX/cdxgen/blob/master/.github/workflows/npm-release.yml#L28 |
@prabhu I saw you already did add the trim ci agent. Anything else I can support here. I hope my change did not trigger the failing of repotests now. |
@Nikemare, trim doesn't seem to be helping. Not sure when the tests started failing but any help would be appreciated! |
@prabhu created a pullrequest with step |
-p
flag added were it was missingls -ltr bomresults
after all steps writing bom files into this folderThis should help to identify long running repotests or were problems exactly occured.