Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log maven errors for multi-module projects by default #826

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

prabhu
Copy link
Collaborator

@prabhu prabhu commented Jan 22, 2024

We have multiple things working against us when it comes to java + maven projects.

  1. We recurse by default. Many maven projects can only be built from a specific directory (rootPath)
  2. We run the maven plugin in aggregate bom mode to reduce false negatives. Many projects can support such aggregation only from specific base modules.
  3. There could be 100s of other factors that could prevent Maven from working smoothly, such as weather, etc.

For now, this PR moves several console.log within an if condition to tune down the logs for multi-module projects.

cc: @heubeck

@prabhu prabhu merged commit b945721 into master Jan 22, 2024
24 checks passed
@prabhu prabhu deleted the feature/tune-maven-log branch January 22, 2024 21:08
Copy link
Contributor

@heubeck heubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's dark outside.
No idea how this will look at light.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants