Fix contraction tree #536
Merged
Fix contraction tree #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anagement and functionality - Renamed PsudoUniTensor to PseudoUniTensor for consistency. - Replaced raw pointers with smart pointers (std::unique_ptr) in PseudoUniTensor to enhance memory safety. - Updated constructors and assignment operators to support move semantics. - Introduced helper functions for optimal tree solving and connected components detection. - Enhanced SearchTree class to utilize the new PseudoUniTensor structure and improved error handling. - Added unit tests for SearchTree functionality, covering various scenarios including basic contraction orders and error cases. This refactor aims to streamline tensor contraction processes and improve overall code maintainability.
…mproved memory management - Updated Node class to inherit from std::enable_shared_from_this for better shared pointer management. - Replaced raw pointers with std::shared_ptr and std::weak_ptr in Node to prevent memory leaks and circular references. - Modified constructors and assignment operators in Node and ContractionTree to support smart pointer usage. - Adjusted methods in ContractionTree to work with shared pointers, enhancing safety and clarity. - Updated related code in RegularGncon and RegularNetwork to accommodate changes in Node handling. This refactor aims to enhance memory safety and maintainability in tensor contraction processes.
…anagement and debugging output - Added debug output for setting root pointers in Node class to aid in tracing. - Introduced a new method `set_root_ptrs()` to streamline root pointer assignment. - Updated constructors to set node names based on children for better identification. - Refactored `reset_nodes()` and `reset_contraction_order()` methods for clearer logic and safety. - Enhanced error handling in `set_root_ptrs()` to manage potential weak pointer issues. - Updated tests to include debug information during network creation. These changes aim to improve the clarity and maintainability of the contraction tree structure, facilitating easier debugging and understanding of tensor relationships.
…ity and functionality - Clear previous base nodes before creating new ones to ensure a fresh state. - Implemented a loop to properly create and assign names to base nodes using smart pointers. - Enhanced the structure of the FromString method for better readability. These changes aim to streamline the initialization of base nodes in the contraction tree, improving maintainability and clarity in the network setup process.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev-master #536 +/- ##
==============================================
+ Coverage 17.85% 23.64% +5.79%
==============================================
Files 211 211
Lines 44766 44911 +145
Branches 14956 15039 +83
==============================================
+ Hits 7992 10620 +2628
- Misses 32636 32641 +5
+ Partials 4138 1650 -2488 ☔ View full report in Codecov by Sentry. |
|
I saw a few commit with clang format. Are you using pre-commit tool? It will auto format for you |
|
I moved from vscode to cursor so my extension setup are messed up. Will fix it. |
…functionality of linear algebra tests.
hunghaoti
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the algorithm described in Faster identification of optimal contraction sequences for tensor networks by Robert N. C. Pfeifer, Jutho Haegeman, Frank Verstraete to fix #506
Raw pointers are replaced with smart pointers for to improve the memory management in
SearchTree,ContractionTree,Node, andPseudoUniTensorclasses. Ranged for loop is used when possible.Need to further tests on edge cases.