Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gpu unit test. #545

Merged
merged 1 commit into from
Dec 27, 2024
Merged

Fix gpu unit test. #545

merged 1 commit into from
Dec 27, 2024

Conversation

hunghaoti
Copy link
Collaborator

  1. Fix Lanczos Gnd unit test cause from putblock using different devices.
  2. Skip ExpM for gpu test since Eig still not implemted, which is needed to do the exponential.
  3. cuda svd cannot give the correct answer if almost elements are zeros. So we skip Svd U1_zeros tests.
  4. The answer of Svd_truncate3 is not correct also cause from the above issue. So I delete it.

1. Fix Lanczos Gnd unit test cause from putblock using different devices.
2. Skip ExpM for gpu test since Eig still not implemted, which is needed to do the exponential.
3. cuda svd cannot give the correct answer if almost elements are zeros. So we skip Svd U1_zeros tests.
4. The answer of Svd_truncate3 is not correct also cause from the above issue. So I delete it.
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.58%. Comparing base (50490b4) to head (6a00436).
Report is 3 commits behind head on dev-master.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev-master     #545   +/-   ##
===========================================
  Coverage       23.58%   23.58%           
===========================================
  Files             211      211           
  Lines           44926    44926           
  Branches        14018    14018           
===========================================
  Hits            10595    10595           
  Misses          32664    32664           
  Partials         1667     1667           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IvanaGyro
Copy link
Collaborator

Just leave a reference. The third problem was addressed in #505.

Copy link
Collaborator

@IvanaGyro IvanaGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the first problem imply there is a bug in the function to put blocks while the device is the GPU?

tests/gpu/linalg_test/linalg_test.cpp Show resolved Hide resolved
tests/gpu/linalg_test/Directsum_test.cpp Show resolved Hide resolved
@IvanaGyro
Copy link
Collaborator

IvanaGyro commented Dec 27, 2024

Feel free to close the conversations to merge the PR.

@hunghaoti
Copy link
Collaborator Author

Does the first problem imply there is a bug in the function to put blocks while the device is the GPU?

The first problem cause since we cannot put a Tensor in GPU device to the UniTensor in CPU device. So we just create Tensors in CPU and put it in UniTensor in CPU. And then transfer to GPU finally.

@hunghaoti hunghaoti merged commit f7368fe into dev-master Dec 27, 2024
4 checks passed
@hunghaoti hunghaoti deleted the haoti/fix_gpu_unit_test branch December 27, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants