Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop test_logical_device_view_contents #319

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Drop test_logical_device_view_contents #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions tests/unit/test_kokkos_serialize_special.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,37 +116,6 @@ TEST_F(KokkosViewContentsTest, test_view_contents_2d_layout) {
EXPECT_EQ(40, alias(1,1));
}

struct TestSpaceNamer {
static constexpr const char* get_name() { return "TestSpace"; }
};

using fake_memory_space = Kokkos::Experimental::LogicalMemorySpace<
Kokkos::HostSpace, Kokkos::DefaultHostExecutionSpace, TestSpaceNamer,
Kokkos::Experimental::LogicalSpaceSharesAccess::no_shared_access>;

// Disable for now while view reconstruction logic is in flux
#if 0
TEST_F(KokkosViewContentsTest, test_logical_device_view_contents) {
// Create an inaccessible View
using LogicalViewType = Kokkos::View<int*, fake_memory_space>;
auto lv = LogicalViewType("lv", 1);

// Initialize a value
Kokkos::deep_copy(lv, 3);

auto ret = checkpoint::serialize<LogicalViewType>(lv);
auto out_view = checkpoint::deserialize<LogicalViewType>(ret->getBuffer());
auto const& out_view_ref = *out_view;

EXPECT_EQ(out_view_ref.extent(0), std::size_t(1));

auto mirror = create_mirror_view(out_view_ref);
Kokkos::deep_copy(mirror, out_view_ref);

EXPECT_EQ(mirror(0), 3);
}
#endif

#if defined(KOKKOS_ENABLE_CUDA)

TEST_F(KokkosViewContentsTest, test_cuda_device_view_contents) {
Expand Down
Loading