Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#351: Update build against vt CI to fail properly #352

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

thearusable
Copy link
Contributor

@thearusable thearusable commented Jun 19, 2024

Fixes #351

This PR changes the parameter used for specifying path to magistrate in ci/build_against_vt.sh from checkpoint_DIR to checkpoint_ROOT.

@thearusable thearusable self-assigned this Jun 19, 2024
@thearusable thearusable marked this pull request as ready for review June 19, 2024 12:02
@cz4rs
Copy link
Contributor

cz4rs commented Jun 19, 2024

@thearusable The description should mention the checkpoint_DIR / checkpoint_ROOT fix as well.

@PhilMiller PhilMiller changed the title #351: Update build agains vt CI to fail properly #351: Update build against vt CI to fail properly Jun 19, 2024
@PhilMiller
Copy link
Member

You could fix the typo in the commit message too, like I did in the description, if there's anything else to touch.

@lifflander lifflander merged commit 19b568f into develop Jun 20, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow fails but still looks like it passes
5 participants