Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#365: add support for Kokkos::Array #366

Merged
merged 5 commits into from
Sep 30, 2024
Merged

#365: add support for Kokkos::Array #366

merged 5 commits into from
Sep 30, 2024
+167 −2

Conversation

nmm0
Copy link
Contributor

@nmm0 nmm0 commented Sep 23, 2024

Closes #365

@cz4rs cz4rs self-requested a review September 23, 2024 16:19
@nmm0 nmm0 marked this pull request as ready for review September 25, 2024 18:53
cz4rs
cz4rs approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@cz4rs cz4rs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@cz4rs
Copy link
Contributor

cz4rs commented Sep 26, 2024

Running the check_guards.sh or generate_header_guards_and_license.py does not modify any files for me 🤔 Not sure why the build is failing in CI.

@cz4rs
Copy link
Contributor

cz4rs commented Sep 26, 2024 •
edited
Loading

@nmm0 Got it, you just need to rebase on top of develop, re-run the script and a bunch of changes will show up:

 //                                kokkos_array.h
-//                 DARMA/checkpoint => Serialization Library
+//                 DARMA/magistrate => Serialization Library
 //

@nmm0
Copy link
Contributor Author

nmm0 commented Sep 26, 2024 •
edited
Loading

ahh makes sense ill rebase

@nmm0 nmm0 force-pushed the 365-add-support-for-serializing-kokkos-array branch from 580a027 to f83becb Compare September 26, 2024 20:00
lifflander
lifflander approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@lifflander lifflander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lifflander lifflander merged commit 50d8d8f into develop Sep 30, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilMiller PhilMiller PhilMiller left review comments

@nlslatt nlslatt nlslatt approved these changes

@cz4rs cz4rs cz4rs approved these changes

@lifflander lifflander lifflander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for serializing Kokkos::Array
5 participants
@nmm0 @cz4rs @PhilMiller @lifflander @nlslatt