Skip to content

Commit

Permalink
#32: clean workflow files and add env variable in pushbasedockerimage…
Browse files Browse the repository at this point in the history
….yml
  • Loading branch information
tlamonthezie committed Jul 31, 2024
1 parent ac4f5f0 commit baaa683
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
VT_TV_TESTS_ENABLED: 'ON' # Build & Test in all configurations
VT_TV_COVERAGE_ENABLED: ${{ matrix.image == 'ubuntu_22.04-gcc_12-vtk_9.3.0-py_3.8' && 'ON' || 'OFF' }} # Coverage only with main test image
VT_TV_PYTHON_BINDINGS_ENABLED: 'ON'
DOCKER_REPOSITORY: pierrpebay/vt-tv # lifflander1/vt
DOCKER_REPOSITORY: lifflander1/vt
name: vt-tv build and test
steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -55,7 +55,7 @@ jobs:
context: .
file: ./ci/docker/build-and-test.dockerfile
build-args: |
BASE_IMAGE=${{ env.DOCKER_REPOSITORY }}:${{ matrix.image }}
BASE_IMAGE=${{ env.DOCKER_REPOSITORY }}:${{ matrix.image }}
VT_TV_TESTS_ENABLED=${{ env.VT_TV_TESTS_ENABLED }}
VT_TV_COVERAGE_ENABLED=${{ env.VT_TV_COVERAGE_ENABLED }}
outputs: type=local,dest=${{ env.OUTPUT_DIR }}
Expand Down
4 changes: 3 additions & 1 deletion .github/workflows/pushbasedockerimage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ jobs:
push_to_registry:
name: Build & Push
runs-on: ubuntu-latest
env:
DOCKER_REPOSITORY: lifflander1/vt
steps:
- name: Check out the repo
uses: actions/checkout@v4
Expand Down Expand Up @@ -74,4 +76,4 @@ jobs:
PYTHON_VERSION=${{ env.PYTHON_VERSION }}
file: ci/docker/make-base.dockerfile
push: true
tags: lifflander1/vt:${{ env.DOCKER_TAG }}
tags: "${{ env.DOCKER_REPOSITORY }}:${{ env.DOCKER_TAG }}"

0 comments on commit baaa683

Please sign in to comment.