Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#98: Make output field optional in yaml configuration #101

Merged
merged 5 commits into from
Aug 12, 2024
Merged

#98: Make output field optional in yaml configuration #101

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
767b431
#98: read output params in if block
cwschilly Aug 5, 2024
452e5b9
#98: clean up fmt::print line
cwschilly Aug 5, 2024
24e5267
#98: add newline to fmt::print()
cwschilly Aug 6, 2024
b9eab74
#98: ensure font size and window size are initialized
cwschilly Aug 6, 2024
faf2f5c
#98: all default values for yaml params
cwschilly Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 43 additions & 30 deletions src/vt-tv/utility/parse_render.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,60 +109,73 @@ void ParseRender::parseAndRender(PhaseType phase_id, std::unique_ptr<Info> info)
}

std::array<std::string, 3> qoi_request = {
config["viz"]["rank_qoi"].as<std::string>(),
config["viz"]["rank_qoi"].as<std::string>("load"),
"",
config["viz"]["object_qoi"].as<std::string>()
config["viz"]["object_qoi"].as<std::string>("load")
};

bool save_meshes = config["viz"]["save_meshes"].as<bool>();
bool save_pngs = config["viz"]["save_pngs"].as<bool>();
bool continuous_object_qoi = config["viz"]["force_continuous_object_qoi"].as<bool>();
bool save_meshes = config["viz"]["save_meshes"].as<bool>(true);
bool save_pngs = config["viz"]["save_pngs"].as<bool>(true);
bool continuous_object_qoi = config["viz"]["force_continuous_object_qoi"].as<bool>(true);

std::array<uint64_t, 3> grid_size = {
config["viz"]["x_ranks"].as<uint64_t>(),
config["viz"]["y_ranks"].as<uint64_t>(),
config["viz"]["z_ranks"].as<uint64_t>()
config["viz"]["z_ranks"].as<uint64_t>(1)
};

double object_jitter = config["viz"]["object_jitter"].as<double>();
double object_jitter = config["viz"]["object_jitter"].as<double>(0.5);

std::string output_dir = config["output"]["directory"].as<std::string>();
std::filesystem::path output_path(output_dir);
std::string output_dir;
std::filesystem::path output_path;
std::string output_file_stem;
uint64_t win_size = 2000;
// Use automatic font size if not defined by user
// 0.025 is the factor of the window size determined to be ideal for the font size
uint64_t font_size = 0.025 * win_size;

// If it's a relative path, prepend the SRC_DIR
if (output_path.is_relative()) {
output_path = std::filesystem::path(SRC_DIR) / output_path;
}
output_dir = output_path.string();
if (save_meshes || save_pngs) {
output_dir = config["output"]["directory"].as<std::string>("output");
output_path = output_dir;

// append / to avoid problems with file stems
if (!output_dir.empty() && output_dir.back() != '/') {
output_dir += '/';
}
// If it's a relative path, prepend the SRC_DIR
if (output_path.is_relative()) {
output_path = std::filesystem::path(SRC_DIR) / output_path;
}
output_dir = output_path.string();

std::string output_file_stem = config["output"]["file_stem"].as<std::string>();
// append / to avoid problems with file stems
if (!output_dir.empty() && output_dir.back() != '/') {
output_dir += '/';
}

output_file_stem = config["output"]["file_stem"].as<std::string>("vttv");

fmt::print("Num ranks={}\n", info->getNumRanks());
fmt::print("Num ranks={}\n", info->getNumRanks());

uint64_t win_size = 2000;
if (config["output"]["window_size"]) {
win_size = config["output"]["window_size"].as<uint64_t>();
}
if (config["output"]["window_size"]) {
win_size = config["output"]["window_size"].as<uint64_t>(2000);
// Update font_size with new win_size
font_size = 0.025 * win_size;
}

// Use automatic font size if not defined by user
// 0.025 is the factor of the window size determined to be ideal for the font size
uint64_t font_size = 0.025 * win_size;
if (config["output"]["font_size"]) {
font_size = config["output"]["font_size"].as<uint64_t>();
if (config["output"]["font_size"]) {
font_size = config["output"]["font_size"].as<uint64_t>();
}
} else {
fmt::print("Warning: save_pngs and save_meshes are both False "
"(no visualization will be generated).\n");
}

// Instantiate render
Render r(
qoi_request, continuous_object_qoi, *std::move(info), grid_size, object_jitter,
output_dir, output_file_stem, 1.0, save_meshes, save_pngs, phase_id
);
r.generate(font_size, win_size);

if (save_meshes || save_pngs) {
r.generate(font_size, win_size);
}

} catch (std::exception const& e) {
std::cout << "Error reading the configuration file: " << e.what() << std::endl;
Expand Down
Loading