#8: Adapt input and output to use compressed JSON format #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwschilly
force-pushed
the
8-adapt-input-and-output-to-use-compressed-json-format
branch
from
bf90fe6 to
b651602
Compare
|
|
cwschilly
force-pushed
the
8-adapt-input-and-output-to-use-compressed-json-format
branch
from
a187dc8 to
4bd910e
Compare
…ean up OpenMP preprocessing
tlamonthezie
force-pushed
the
8-adapt-input-and-output-to-use-compressed-json-format
branch
from
6da8f58 to
0f6c187
Compare
tlamonthezie
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Seems to be ok for input part as the unit test PASSED.
@cwschilly I have just one question: I am not sure about what output means in the issue description because I don't see anything about output in the PR. There is some JSONGenerator class but it does not seem to be related to that issue
|
@tlamonthezie This issue is from over a year ago; my guess is that when it was opened, we thought that vt-tv might use a JSON writer. However, at least at the moment, we never write out JSON, so I don't think there's any work to be done for output |
cwschilly
deleted the
8-adapt-input-and-output-to-use-compressed-json-format
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8
This changes vttv so that we read in every file in the input data directory. This means that there can't be extra files in there (for example, both compressed and un-compressed versions of the input data).
Also reworks OpenMP preprocessing, since the changes to JSON reading affected the
omp parallel forinparse_render.cc.