#111: Add support for seq_id object identifiers
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlamonthezie
changed the title
seq_id object identifiersseq_id object identifiers
cwschilly
approved these changes
Sep 16, 2024
There was a problem hiding this comment.
Just want to point out that this doesn't make any changes to the json_generator (meaning that every id will be written out as id and not seq_id).
However, I don't think this is a problem because 1) vt-tv's JSON writer is currently not used anywhere and 2) I don't know of any plans to use it in the future.
lifflander
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111
This PR enables to use
seq_idobject identifier ifidis not defined(
seq_idis used for data files generated by the LBAF data files maker, since LBAF PR 528)The JSON reader will read the
idkey if available and will useseq_idin the other case as the object id.