Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#86: Resolve build warnings #87

Merged
merged 3 commits into from
Jul 17, 2024
Merged

#86: Resolve build warnings #87

merged 3 commits into from
Jul 17, 2024

Conversation

cwschilly
Copy link
Contributor

@cwschilly cwschilly commented Jul 16, 2024 •
edited
Loading

Fixes #86

This will allow vt's VT_TV_ENABLED CI pipeline to pass

@cwschilly cwschilly linked an issue Jul 16, 2024 that may be closed by this pull request
Resolve build warnings #86
Closed
@cwschilly cwschilly requested a review from pierrepebay July 16, 2024 20:55
@cwschilly cwschilly self-assigned this Jul 16, 2024
@cwschilly cwschilly requested a review from lifflander July 17, 2024 17:21
pierrepebay
pierrepebay requested changes Jul 17, 2024
View reviewed changes
cmake/turn_on_warnings.cmake Outdated Show resolved Hide resolved
cmake/turn_on_warnings.cmake Outdated Show resolved Hide resolved
examples/CMakeLists.txt Outdated Show resolved Hide resolved
tests/CMakeLists.txt Outdated Show resolved Hide resolved
@cwschilly cwschilly requested review from nlslatt and pierrepebay July 17, 2024 17:42
pierrepebay
pierrepebay approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@pierrepebay pierrepebay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks for modifications 👍🏻

nlslatt
nlslatt reviewed Jul 17, 2024
View reviewed changes
Copy link
Contributor

@nlslatt nlslatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Should we enable -Werror in the CI?

@cwschilly cwschilly requested a review from tlamonthezie July 17, 2024 18:10
@cwschilly
Copy link
Contributor Author

This looks good. Should we enable -Werror in the CI?

I think we should, especially since vt's vt-tv pipeline was failing with -Werror. @pierrepebay @tlamonthezie Do you have any thoughts?

@pierrepebay
Copy link
Contributor

This looks good. Should we enable -Werror in the CI?

I think we should, especially since vt's vt-tv pipeline was failing with -Werror. @pierrepebay @tlamonthezie Do you have any thoughts?

I think so, @tlamonthezie once this is merged could you add this parameter in your build.sh in #85, and enable it when calling it in CI?

@nlslatt nlslatt merged commit f76d422 into master Jul 17, 2024
6 checks passed
@cwschilly cwschilly deleted the 86-resolve-build-warnings branch July 17, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pierrepebay pierrepebay pierrepebay approved these changes

@nlslatt nlslatt nlslatt approved these changes

@lifflander lifflander Awaiting requested review from lifflander

@tlamonthezie tlamonthezie Awaiting requested review from tlamonthezie

Assignees

@cwschilly cwschilly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resolve build warnings
3 participants
@cwschilly @pierrepebay @nlslatt