Added global site config and a floating Give a Talk CTA #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TrystonPerry Looks pretty banger. Do you think we should add a way for them to dismiss the cta? |
Hmm. We could change it so it only shows on the home page. That would be simple. |
samholmes
requested changes
Sep 23, 2024
There was a problem hiding this comment.
Why is this a merge commit? Does it have multiple parents? Let's keep our commits flat for PRs and only merge PRs
There was a problem hiding this comment.
Sorry, I used the resolve conflicts button in github's ui. I didn't know it would do a merge.
There was a problem hiding this comment.
@TrystonPerry Please remove c63f6b2 when you rebase
samholmes
force-pushed
the
floating-talk-request-widget
branch
from
c63f6b2 to
ad53b54
Compare
samholmes
approved these changes
Sep 27, 2024
| href={links.talkSubmissionUrl} | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="fixed flex items-center px-6 py-3 space-x-2 font-bold text-white transition-all duration-300 ease-in-out transform -translate-x-1/2 rounded-full shadow-lg bg-gradient-to-r from-blue-500 to-purple-600 sm:bottom-12 bottom-6 left-1/2 hover:from-blue-600 hover:to-purple-700 hover:scale-105 animate-pulse" |
There was a problem hiding this comment.
Included sm:bottom-12 bottom-6 for responsiveness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.