Ban sun.misc.Unsafe
#4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiritofeng
force-pushed
the
ban-unsafe
branch
from
b627bb2 to
84d4aef
Compare
quantum5
reviewed
Dec 21, 2023
src/main/java/ca/dmoj/java/DisallowedClassesClassFileTransformer.java
Outdated
Show resolved
Hide resolved
kiritofeng
force-pushed
the
ban-unsafe
branch
from
84d4aef to
2c02786
Compare
kiritofeng
force-pushed
the
ban-unsafe
branch
2 times, most recently
from
b4244af to
cf04463
Compare
quantum5
reviewed
Dec 21, 2023
src/main/java/ca/dmoj/java/DisallowedClassesClassFileTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/dmoj/java/DisallowedClassesClassFileTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/dmoj/java/DisallowedClassesClassFileTransformer.java
Outdated
Show resolved
Hide resolved
kiritofeng
force-pushed
the
ban-unsafe
branch
3 times, most recently
from
977a77d to
b4f5732
Compare
|
Tested this against DMOJ/judge-server@d50d7fb and it successfully blocks |
kiritofeng
force-pushed
the
ban-unsafe
branch
from
b4f5732 to
abbc93e
Compare
quantum5
approved these changes
Dec 22, 2023
src/main/java/ca/dmoj/java/DisallowedClassesClassFileTransformer.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/dmoj/java/DisallowedClassesClassFileTransformer.java
Outdated
Show resolved
Hide resolved
kiritofeng
force-pushed
the
ban-unsafe
branch
from
abbc93e to
a11d919
Compare
quantum5
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ban
sun.misc.Unsafeby default. It can be re-enabled by passing theunsafeoption.If you're using
sun.misc.Unsafein a contest-programming setting, odds are you're doing something silly anyways...