Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor submission activity graph issues #1573

Merged
merged 3 commits into from
Nov 21, 2020

Conversation

Ninjaclasher
Copy link
Member

  1. Shift weekdays so they match the submission activity graph
  2. Prevent infinite scrolling when user has no submissions
  3. Update submission activity header text when scrolling

Refs #236.

This is to match Github's contribution activity graph.
Otherwise, it looks weird when scrolling, as the header
still shows the current year's submission activity while
everything else shows year-specific submission activity.
@codecov-io
Copy link

Codecov Report

Merging #1573 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1573   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files         213      213           
  Lines       12145    12145           
=======================================
  Hits         5593     5593           
  Misses       6552     6552           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4f0b69...99884cc. Read the comment docs.

Copy link
Contributor

@fluix-dev fluix-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xyene Xyene merged commit 465fa25 into DMOJ:master Nov 21, 2020
@Ninjaclasher Ninjaclasher deleted the sub-activity-fixes branch March 20, 2022 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants