Update test case 2 (Capabilities) to support SPDM 1.3 #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than the supported algorithms block, I'm not seeing anything immediately obvious that is new. Mostly just things that will trigger new checks in later tests. |
|
Hmm also need to update the docs. |
|
Since this results in 2.5 and 2.7 being basically identical, would it make more sense to change 2.5 to 1.2+ and have a specific test for anything only in 1.3? |
This updates test case 2 to check for and confirm report of SPDM 1.3 in GET_CAPABILITIES. All tests are the same at this time, and the test body for 1.2 has been made common with checks to toggle support for 1.3. This does not validate any new capabilities, such as the supported algorithms block, added in SPDM 1.3. Signed-off-by: Will Marone <[email protected]>
wmaroneAMD
force-pushed
the
validator-work
branch
from
078d53b to
a5af14d
Compare
|
If they are identical, we can just use 1.2+. |
|
Ok. I will unify the general case and create a specific test for the 1.3 feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates test case 2 to check for and confirm report of SPDM 1.3 in GET_CAPABILITIES. All tests are the same at this time, and the test body for 1.2 has been made common with checks to toggle support for 1.3.
This does not validate any new capabilities, such as the supported algorithms block, added in SPDM 1.3.