Add parameters to libspdm_write_certificate_to_nvm #2901
Conversation
|
@rw8896 as well. |
|
|
||
| uint32_t base_hash_algo, uint32_t base_asym_algo | ||
| #if LIBSPDM_SET_CERT_PARAMS | ||
| , bool *need_reset, bool *is_busy |
There was a problem hiding this comment.
I am wondering if we need is_busy for CSR API as well.
There was a problem hiding this comment.
Yes probably. I can do that in a separate pull request, but let me rename LIBSPDM_SET_CERT_PARAMS to something more generic so that CSR can leverage it as well.
There was a problem hiding this comment.
See #2893 (comment).
There was a problem hiding this comment.
Can we file a separate issue? I feel #2893 only handles INVALID_REQUEST.
| if ((fp_out = open(file_name, O_WRONLY | O_TRUNC)) == -1) { | ||
| printf("Unable to open file %s\n", file_name); | ||
| return false; | ||
|
|
There was a problem hiding this comment.
Do we need to handle the (cert_chain == NULL) case?
There was a problem hiding this comment.
That's a separate issue. I just added
if (g_set_cert_is_busy) {
*is_busy = true;
and everything got adjusted. But yes, it looks like the "sample" implementation doesn't support erasing a certificate slot.
There was a problem hiding this comment.
Yes, the handling could be done in a separate change.
Signed-off-by: Steven Bellock <[email protected]>
Fix DMTF#2873. Signed-off-by: Steven Bellock <[email protected]>
steven-bellock
force-pushed
the
fix-2873
branch
from
bb3bc2f to
26e0a5d
Compare
| * This macro will be removed when libspdm 4.0 is released. | ||
| */ | ||
| #ifndef LIBSPDM_SET_CERT_CSR_PARAMS | ||
| #define LIBSPDM_SET_CERT_CSR_PARAMS 1 |
There was a problem hiding this comment.
This should not be 1. I'll fix it in the pull request that fixes #2908.
There was a problem hiding this comment.
Actually this needs a separate pull request, as it is breaking builds.
Fix #2873.