Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize spdm_device_secret_lib_sample #2910

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

jyao1
Copy link
Member

@jyao1 jyao1 commented Nov 26, 2024

The original code is hard to maintain because we put so many features in one lib.c.

split lib.c to multiple smaller files.
cert.c -> read_pub_cert.c

Only code move, zero code change.

@jyao1 jyao1 force-pushed the reorg_secret_lib_sample branch from 92a2663 to e666db1 Compare November 26, 2024 05:17
@steven-bellock steven-bellock changed the title reorg spdm_device_secret_lib_sample Reorganize spdm_device_secret_lib_sample Nov 26, 2024
@steven-bellock steven-bellock added the refactor Should not affect functionality label Nov 26, 2024
The original code is hard to maintain because we put so many features in one lib.c.

split lib.c to multiple smaller files.
rename cert.c to read_pub_cert.c

Only code move, zero code change.

Signed-off-by: Jiewen Yao <[email protected]>
@jyao1 jyao1 force-pushed the reorg_secret_lib_sample branch from e666db1 to f14b0e8 Compare November 27, 2024 00:38
@jyao1 jyao1 requested a review from steven-bellock November 27, 2024 00:39
@jyao1 jyao1 merged commit 46a49a4 into DMTF:main Nov 27, 2024
97 checks passed
@jyao1 jyao1 deleted the reorg_secret_lib_sample branch December 4, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Should not affect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants