SCLK Bug fixes #44
Merged
SCLK Bug fixes #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kelvinrr
commented
Nov 4, 2024
| @@ -30,14 +30,15 @@ | |||
| "kernels" : "pck00010_msgr_v[0-9]{2}.tpc" | |||
| } | |||
| }, | |||
| "deps" : ["/mdis_att", "/messenger"] | |||
There was a problem hiding this comment.
this caused errors when loading mdis CKs
Comment on lines
+241
to
+252
| try { | ||
| scs2e_c(frameCode, sclk.c_str(), &et); | ||
| checkNaifErrors(); | ||
| SPDLOG_DEBUG("strsclktoet({}, {}, {}) -> {}", frameCode, mission, sclk, et); | ||
| } | ||
| catch(exception &e) { | ||
| // we want the platforms code, if they passs in an instrument code (e.g. -85600), truncate it to (-85) | ||
| frameCode = (abs(frameCode / 1000) > 0) ? frameCode/1000 : frameCode; | ||
| scs2e_c(frameCode, sclk.c_str(), &et); | ||
| checkNaifErrors(); | ||
| SPDLOG_DEBUG("strsclktoet({}, {}, {}) -> {}", frameCode, mission, sclk, et); | ||
| } |
There was a problem hiding this comment.
Some missions like Viking need to use the full IK ID in order to get correct SCLK times, forcing the frame code from -43010 to -43 for some these mission caused confusing errors because it loaded the wrong SLCK ID.
The try except should solve this, try the key as passed in, if it fails try the short code. So for MRO Crism, -74010 will fail then try -74 and pass. But for Viking, which wants the code -27999 will pass the first time and won't get the incorrect code -74.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Licensing
This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words: