Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing tests #618

Merged
merged 2 commits into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci_testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,13 @@ jobs:
run: |
cd build
ctest -VV
- name: Upload Coverage
uses: codecov/codecov-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
fail_ci_if_error: true
verbose: true
if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.9'
# - name: Upload Coverage
# uses: codecov/codecov-action@v1
# with:
# token: ${{ secrets.CODECOV_TOKEN }}
# fail_ci_if_error: true
# verbose: true
# if: matrix.os == 'ubuntu-latest' && matrix.python-version == '3.9'

Build-Docs:
runs-on: ubuntu-latest
Expand Down
14 changes: 13 additions & 1 deletion ale/drivers/apollo_drivers.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ def detector_center_sample(self):
class ApolloPanIsisLabelIsisSpiceDriver(LineScanner, IsisLabel, IsisSpice, NoDistortion, Driver):

@property
def instrument_name(self):
def instrument_id(self):
"""
The name of the instrument.

Expand All @@ -158,6 +158,18 @@ def instrument_name(self):
return id_lookup[super().instrument_id]


@property
def instrument_name(self):
"""
The name of the instrument.

Returns
-------
str
The short text name for the instrument
"""
return "APOLLO PANORAMIC CAMERA"

@property
def sensor_model_version(self):
"""
Expand Down
Loading