Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the dependency on getopt.h #380

Merged
merged 2 commits into from
Apr 25, 2022
Merged

Conversation

oleg-alexandrov
Copy link
Collaborator

I added some simple parsing which assumes each option has only one value. We could incorporate getopt.h into the code but that one is GPL, which can be problematic. This seems to work. Let's see how the windows build is working out.

@oleg-alexandrov
Copy link
Collaborator Author

I think it made it. Now, it look that the recent logic Jessie put in, related to OrbitalPushFrameSensorModel, is making some tests fail. But nothing related to the tool I am adding.

Copy link
Contributor

@jessemapel jessemapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super happy about how fragile the parsing is here. I'm going to put in a new issue to see if there are any header only or lightweight, non-licensing issue, tools we can pull in to make this happen.

@oleg-alexandrov
Copy link
Collaborator Author

Thanks for the merge. Discussion to be continued at #381.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants