Skip to content

Commit

Permalink
Remove partial loading of submission file.
Browse files Browse the repository at this point in the history
Similar to #2241 this gets rid of the only other partial query.

Submission files should be pretty small and only the jury submission page displays this information anyway, so it should be safe to load the whole model.
  • Loading branch information
nickygerritsen committed Nov 25, 2023
1 parent fb7871f commit f23a920
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion webapp/src/Controller/Jury/SubmissionController.php
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ public function viewAction(
->leftJoin('s.files', 'f')
->leftJoin('s.external_judgements', 'ej', Join::WITH, 'ej.valid = 1')
->leftJoin('s.contest_problem', 'cp')
->select('s', 't', 'p', 'l', 'c', 'partial f.{submitfileid, filename}', 'cp', 'ej')
->select('s', 't', 'p', 'l', 'c', 'f', 'cp', 'ej')
->andWhere('s.submitid = :submitid')
->setParameter('submitid', $submitId)
->getQuery()
Expand Down

0 comments on commit f23a920

Please sign in to comment.