Use Jetbrains linters for QA #2270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll first try to get the PHPstan baseline smaller/empty. |
We can do this for all languages Jetbrains supports, for now this only gives what one already gets if/when using PhpStorm. This will directly upload issues to the PR and upload findings in the Security tab. We can even fail if new issues are found (or accepted in the baseline).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can do this for all languages Jetbrains supports, for now this only gives what one already gets if/when using PhpStorm.
This will directly upload issues to the PR and upload findings in the Security tab. We can even fail if new issues are found (or accepted in the baseline).
I've checked with @nickygerritsen and the findings seem to be new compared to PHPStan and also most of the time seem to make sense.
Same as #2263 but the branch needs to be in the organisation for this to work as this needs a secret, we can decide to allow this on forks with some GA CI magic but that would make it possible to extract the secret.