Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial code for a mobile friendly scoreboard. #2447

Merged
merged 15 commits into from
Nov 22, 2024
Merged

Conversation

nickygerritsen
Copy link
Member

Missing:

  • ❤️.
  • Probably some logic based on whether things are enabled (like problems). Affiliation display logic should be mostly there.
  • Extensive testing for non-finals settings.
  • Maybe some cleanup of the code/logic.
  • Maybe not do this on non public scoreboards?

But we want to use this for the public scoreboard in Luxor, so hence this initial PR.

@meisterT
Copy link
Member

meisterT commented Apr 8, 2024

Maybe not do this on non public scoreboards?

Agreed.

What is strange: I looked now on my phone (and not with chrome devtools) and it is way too wide... but only until the first refresh, then it's fine. Do we fix the width too late?

@nickygerritsen
Copy link
Member Author

Might be that I broke something when moving this to the js file. Will check

@meisterT
Copy link
Member

meisterT commented Apr 8, 2024

I quickly looked into the hearts. It is non-trivial to re-use the same code, so we might have to duplicate it.

@nickygerritsen
Copy link
Member Author

Might be that I broke something when moving this to the js file. Will check

Should be fixed now, it indeed executed the javascript before the page was loaded, which broke when I moved the code to the .js file.

It now also only shows the mobile scoreboard on the public page.

@nickygerritsen nickygerritsen force-pushed the mobilefriendly branch 2 times, most recently from de0068c to c0f9b32 Compare September 6, 2024 09:52
@vmcj
Copy link
Member

vmcj commented Sep 6, 2024

@nickygerritsen you want to retarget this to wfastana?

@nickygerritsen
Copy link
Member Author

I rebased it on Astana then rebased Astana on this so it's already there. Changing the target will tell you hopefully there are no changes

@meisterT
Copy link
Member

For the record: Pending submissions didn't work in the end, but we may have broken them by the triangle thingy in the jury interface.

@mpsijm
Copy link
Contributor

mpsijm commented Oct 29, 2024

Looking quite fancy already 😄 Some feedback: there's some empty space below the country flag, that can be used for the list of problems. In the past BAPC, there were 13 problems, of which the 13th was on a new line, but it would've fit if this empty space had been used:

Screenshot

Of course, there will always be a number of problems where the last one will have to be on a new line, but on mobile, every little bit of space helps 😄

P.S. note that the target branch is still wfluxor 🙂

@nickygerritsen
Copy link
Member Author

@mpsijm you seem to have frontend skills. Do you want to try this?
I can rebase the branch on main and target it to main

@nickygerritsen nickygerritsen changed the base branch from wfluxor to main November 22, 2024 11:02
@nickygerritsen
Copy link
Member Author

Looking quite fancy already 😄 Some feedback: there's some empty space below the country flag, that can be used for the list of problems. In the past BAPC, there were 13 problems, of which the 13th was on a new line, but it would've fit if this empty space had been used:

Screenshot

Of course, there will always be a number of problems where the last one will have to be on a new line, but on mobile, every little bit of space helps 😄

P.S. note that the target branch is still wfluxor 🙂

I fixed this, it now goes below the flags.

@nickygerritsen nickygerritsen added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit 6a6ae10 Nov 22, 2024
33 checks passed
@nickygerritsen nickygerritsen deleted the mobilefriendly branch November 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants