-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial code for a mobile friendly scoreboard. #2447
Conversation
Agreed. What is strange: I looked now on my phone (and not with chrome devtools) and it is way too wide... but only until the first refresh, then it's fine. Do we fix the width too late? |
Might be that I broke something when moving this to the js file. Will check |
I quickly looked into the hearts. It is non-trivial to re-use the same code, so we might have to duplicate it. |
Should be fixed now, it indeed executed the javascript before the page was loaded, which broke when I moved the code to the .js file. It now also only shows the mobile scoreboard on the public page. |
de0068c
to
c0f9b32
Compare
@nickygerritsen you want to retarget this to |
I rebased it on Astana then rebased Astana on this so it's already there. Changing the target will tell you hopefully there are no changes |
For the record: Pending submissions didn't work in the end, but we may have broken them by the triangle thingy in the jury interface. |
Looking quite fancy already 😄 Some feedback: there's some empty space below the country flag, that can be used for the list of problems. In the past BAPC, there were 13 problems, of which the 13th was on a new line, but it would've fit if this empty space had been used: Of course, there will always be a number of problems where the last one will have to be on a new line, but on mobile, every little bit of space helps 😄 P.S. note that the target branch is still |
@mpsijm you seem to have frontend skills. Do you want to try this? |
- Make team names not fall of the screen by calculating their max width. - Make non mobile scoreboard not left-aligned. - Add a bit of margin to the header. - Make the problem boxes right aligned. - Change the card at the top to show 2 lines (name + contestt time) on mobile.
2ed53a1
to
bad0883
Compare
I fixed this, it now goes below the flags. |
106450c
to
1de27f0
Compare
Missing:
But we want to use this for the public scoreboard in Luxor, so hence this initial PR.