-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Source Code and Docs to gource-log GitHub Action #1
Conversation
Signed-off-by: Isaac Milarsky <[email protected]>
Signed-off-by: Isaac Milarsky <[email protected]>
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, it looks like the .github/codejson
directory is missing the hooks
dir and the actual code.json
file. Did you use repo-scaffolder to add docs to the project? If so, it looks like it didn't copy over all the needed files then which is something I'll have to fix.
https://github.com/DSACMS/repo-scaffolder/tree/main/tier3/%7B%7Bcookiecutter.project_slug%7D%7D/.github/codejson
One outstanding question but otherwise this is a solid start for this repo!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last thing oops!
I did use repo-scaffolder to build a tier 3 repo. The missing hooks is def worth looking into |
Oops ignore me I misread and turns out the repo has the hooks dir and the rest of the files! |
Signed-off-by: Isaac Milarsky <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After resolving the nitpicks, this all LGTM!!!!
Signed-off-by: Isaac Milarsky <[email protected]>
Add Source Code and Docs to gource-log GitHub Action
Problem
The gource-log repository was previously not ready to be out-bounded as a public DSACMS repo.
Solution
I have created a tier 3 repository using repo-scaffolder and then added the source code and required documentation to the repository.
Test Plan
sudo act -a build