Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Spring Dependences & HAL Browser #8208

Closed
wants to merge 19 commits into from

Conversation

tdonohue
Copy link
Member

@tdonohue tdonohue commented Mar 14, 2022

References

Description

NOTE: This PR has a few IT cleanup commits which overlap with PR #8195, as these changes were necessary in both these PRs to get all tests to pass. After one PR is merged though, I'll rebase the other.

Instructions for Reviewers

  • Review/scan code changes
  • More importantly, install this PR & try out the HAL Browser at http://localhost:8080/server/
    • Make sure all normal actions work properly. Browse around, try login & logout, etc.
    • You may notices some minor differences in style/CSS after the upgrade to Bootstrap 4, but all buttons, etc should work fine.

tdonohue added 19 commits March 10, 2022 15:07
…s which must be loaded later / on first use.
…ve they are not required, but not set that way in controller.
…. Also add CustomPostForm script from Spring Data REST v3.3.x
@tdonohue tdonohue added high priority interface: REST API v7+ REST API for v7 and later (dspace-server-webapp module) dependencies Pull requests that update a dependency file labels Mar 14, 2022
@tdonohue tdonohue added this to the 7.3 milestone Mar 14, 2022
@tdonohue tdonohue self-assigned this Mar 14, 2022
@tdonohue
Copy link
Member Author

NOTE FOR REVIEWERS: This PR passes all required tests despite the red (❌ ). It seems to be failing a Snyk check simply because it cannot access the Snyk account anymore. Unfortunately, I don't see any way to remove that Snyk check from this PR other than by recreating the PR entirely. I have however removed this Snyk check from future PRs, as it seems like something changed in Snyk recently that causes it to be less stable for PR checks.

@tdonohue
Copy link
Member Author

Close & reopen to re-run tests & see if it triggers GitHub to remove the misleading red ❌ .

@tdonohue
Copy link
Member Author

Close & reopen to re-run tests & see if it triggers GitHub to remove the misleading red ❌ .

@tdonohue tdonohue closed this Mar 16, 2022
@tdonohue tdonohue closed this Mar 16, 2022
@tdonohue tdonohue reopened this Mar 16, 2022
@tdonohue tdonohue reopened this Mar 16, 2022
@tdonohue
Copy link
Member Author

Closing this PR in favor of #8215 (which is a recreation of this same PR). GitHub has somehow messed up this PR...the comments above are duplicating, etc. Might be a temporary issue, but recreated the PR just in case.

@tdonohue tdonohue closed this Mar 16, 2022
@tdonohue tdonohue deleted the update_spring_deps branch March 16, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file high priority interface: REST API v7+ REST API for v7 and later (dspace-server-webapp module)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant