-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow input of alternative text for collection and community logos/th… #3389
base: main
Are you sure you want to change the base?
Allow input of alternative text for collection and community logos/th… #3389
Conversation
…chema to store thumbnail descriptions of collections and communities
Hi @DanGastardelli, |
Hi @DanGastardelli, |
…com/DanGastardelli/dspace-angular into UpdatingAlternativeTextInThumbnails
Hi @DanGastardelli, |
Hi @DanGastardelli, |
Hi @DanGastardelli, |
Allow input of alternative text for collection and community logos/thumbnails
References
Fixes #1306
Requires DSpace/DSpace#9875
This change was addressed in #1306, which now allows detailed description of thumbnail images of items, collections, and community logos (also recognized by screen readers).
Description
First, logic was created using OnInit in the thumbnail component to bring the thumbnail description value into the "alt" text contained in the image tag in the HTML. Fields were then created for insertion in the creation and editing of communities and collections that allowed the insertion of details about the logos involved and finally the creation of translation keys for these fields.
Instructions for reviewers
Firstly, you need to use the backend of this PR DSpace/DSpace#9875.
List of changes in this PR:
*In the html of the components of the community page and the collection page, conditionals were inserted and check if there is a custom description and insert the variable with the description in the alternative text.
Include guidance on how to test or review your PR.
To test, simply create a collection and community that contains a logo. In the “Thumbnail description” field, fill in the data for this logo and finally inspect the logo or use a screen reader on the logo to validate the description entered. Now as for the items, just insert a bitstream and create the thumb by running filter-media in the backend. After that, go to item editing and go to the bitstream tab and edit the thumbnail description and then go to the item and hover your screen reader over the image or inspect it to see if the description matches what you entered.