Another implementation to enabled embedded-hal 1.0.0 based on esp-hal #15
Conversation
I'm not keen on maintaining compatibility with both embedded-hal 1.0.0 and 0.2.7 in my project, so it might be a good idea to upgrade. Also: - Replaced "esp32-hal" to "esp-hal" to accommodate more ESP series chips, such as ESP32c3 (https://github.com/zephyr-atomi/esp32c3-exp). - However, this raises another issue: is a specific backend, for example "esp32", a good idea? Typically, non-ESP32 users might skip the provided esp32-interrupt and use their own backend (esp32c3 / stm32f1xx / rp2040 / ...). Since "loadcell" is a HAL-level library, it might be better not to lock it to just ESP32. Maybe we can consider removing the interrupt; after all, implementing interrupts seems challenging in embedded-hal: rust-embedded/embedded-hal#57
| Delay: embedded_hal::blocking::delay::DelayUs<u32>, | ||
| SckPin: OutputPin + embedded_hal::digital::OutputPin<Error = Infallible>, | ||
| DTPin: InputPin + embedded_hal::digital::InputPin<Error = Infallible>, | ||
| Delay: embedded_hal::delay::DelayNs, |
There was a problem hiding this comment.
If you change this from uS to nS, you will need to update the calls by a factor of 1000
|
Hi Zephyr Thank you for the PR. I think it is good to bring the crate up to v1 of the To your further point, note that the base version of this library is actually compatible with Interrupts are a mess at the moment, but I think the base we have implemented for now is a good one, and defining the interface via traits makes it pretty easy to extend. Once The interrupt feature should and can be extended to support more devices via more flags and config checks, but I am not going to do that since I'm fully committed to the ESP32 ;-) . I, of course, welcome any other implementations for interrupts on other devices. |
|
Hi Dane, Thanks for your reply! Yes, I realize that esp32-hal is an optional dependency, primarily activated when using interrupts. If you are focused on ESP32, keeping esp-hal is fine. My system uses RP2040 / STM32 / ESP (mostly ESP32C3), so I encounter the above issue. Do you have any suggestions for this code? If you are inclined to merge this PR, I can make changes based on your suggestions for you to merge. Or, you could write a commit yourself to enable embedded-hal 1.0.0. My main interest is in using the loadcell crate with latest embedded-hal. Best Regards, |
|
Hi Zephyr I am happy to merge your PR! I have made one suggestion that addresses the unit of our delay class. I would also encourage you to share the code required to get the examples working on your RP2040 or STM32, based on |
|
Hi Zephyr, any plans to look into the units of the delay class? I think we need a multiplier if we change from ms to us |
|
This has gone stale |
Enabled embedded-hal 1.0.0.
I'm not keen on maintaining compatibility with both embedded-hal 1.0.0 and 0.2.7 in my project, so it might be a good idea to upgrade. Also: