Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more unit tests for float parsing #36

Merged
merged 2 commits into from
Aug 10, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
doc: why float can be described using 0x
louiscaron committed Aug 10, 2024
commit 6e263bde55fdbd6c28912590d2c51d6fc353b2ce
6 changes: 6 additions & 0 deletions a2lfile/src/parser.rs
Original file line number Diff line number Diff line change
@@ -598,6 +598,9 @@ impl<'a> ParserState<'a> {
pub(crate) fn get_float(&mut self, context: &ParseContext) -> Result<f32, ParserError> {
let token = self.expect_token(context, A2lTokenType::Number)?;
let text = self.get_token_text(token);
// some vendor tools are defining the characteristic UpperLimit and LowerLimit
// (float values from specifications) using 0xNNN for characteristics that
// are actually integers.
if text.starts_with("0x") || text.starts_with("0X") {
match u64::from_str_radix(&text[2..], 16) {
Ok(num) => Ok(num as f32),
@@ -617,6 +620,9 @@ impl<'a> ParserState<'a> {
pub(crate) fn get_double(&mut self, context: &ParseContext) -> Result<f64, ParserError> {
let token = self.expect_token(context, A2lTokenType::Number)?;
let text = self.get_token_text(token);
// some vendor tools are defining the characteristic UpperLimit and LowerLimit
// (float values from specifications) using 0xNNN for characteristics that
// are actually integers.
if text.starts_with("0x") || text.starts_with("0X") {
match u64::from_str_radix(&text[2..], 16) {
Ok(num) => Ok(num as f64),