-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ChunkSplitters to 3.0 #40
Conversation
Thanks for this. I forgot there was a new release for that package. From https://github.com/JuliaFolds2/ChunkSplitters.jl/blob/main/CHANGELOG.md, I think instead the fix is to change |
Yeah you are right, I forgot about that. Maybe in some places where the indices are not needed, we can simply use Hmm, I have no idea why the tests are failing. It seems that probably in some tests there are only one element with two threads? |
Do they fail with v2? You probably need to look at what |
OK, I now understand the issue. We need to add |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
==========================================
- Coverage 97.86% 97.86% -0.01%
==========================================
Files 22 21 -1
Lines 1216 1215 -1
==========================================
- Hits 1190 1189 -1
Misses 26 26 ☔ View full report in Codecov by Sentry. |
Thanks for looking into this! I appreciate it. If you can remove the vscode settings file and bump the package version I'll merge and make a new release |
And yeah they take a bit of time unfortunately, sorry about that.. probably longer than is needed but back when I was first developing the package it helped to be a bit exhaustive 😅 |
New version has now been released. Thanks @henry2004y! |
ChunkSplitters.jl 3.0 introduces a breaking change to the
chunks
API, wheren
(the number of chunks) is now a keyword parameter.