Skip to content

Commit

Permalink
- Add sub dependencies to avoid Ruby 3.3.5 warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
DannyBen committed Sep 4, 2024
1 parent 6bfb1bc commit 30b7318
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
4 changes: 4 additions & 0 deletions bashly.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ Gem::Specification.new do |s|
s.add_dependency 'requires', '~> 1.1.0'
s.add_dependency 'tty-markdown', '~> 0.7'

# Sub-dependenceis (Ruby 3.3.5 warnings)
s.add_dependency 'logger' # required by filewatcher
s.add_dependency 'ostruct' # required by json

# Ruby 3.0 comes with Psych 3.3.0, which does not have the `unsafe_load`
# ref: https://github.com/ruby/psych/commit/cb50aa8d3fb8be01897becff77b4922b12a0ab4c
s.add_dependency 'psych', '>= 3.3.2', '< 7'
Expand Down
1 change: 0 additions & 1 deletion spec/approvals/libraries/render/mandoc/render-1-download.1
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,3 @@ EXAMPLES

download example.com ./output -f

Version 0.1.0 MONTH YEAR ... APPNAME
4 changes: 1 addition & 3 deletions spec/bashly/libraries/render_mandoc_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,9 @@
.to match_approval('libraries/render/mandoc/render-1-download.md')
.except(/\w{3,9} 202\d/, 'MONTH YEAR')

expect(`man "#{target}/download.1" | col -bx`)
expect(`man "#{target}/download.1" | col -bx | sed '$d'`)
.to match_approval('libraries/render/mandoc/render-1-download.1')
.diff(leeway)
.except(/\w{3,9} 202\d.*/, 'MONTH YEAR ... APPNAME')
end
end

Expand All @@ -41,7 +40,6 @@
it 'saves a markdown and man files for each command' do
expect { subject.instance_eval render_script }
.to output_approval('libraries/render/mandoc/render-2')
.except(/\w{3,9} 202\d.*/, 'MONTH YEAR ... APPNAME')

expect(File.read "#{target}/cli-download.md")
.to match_approval('libraries/render/mandoc/render-2-download.md')
Expand Down

0 comments on commit 30b7318

Please sign in to comment.