Support array in default

[EmilyGraceSeville7cf]

closes #463

The easiest way to add array support for default.

To implement dependency between repeatable and default properties here if is required, but it means that common properties to then and else branches should be declared inside definitions. Will u accept such change if I make it?

[DannyBen]

I think what you have done here is sufficient, no? I prefer simplicity whenever possible.

Have you figured out how come the check-jsonschema did not fail when only string is allowed, and it was an array?

[EmilyGraceSeville7cf]

I think what you have done here is sufficient, no? I prefer simplicity whenever possible.

Got it. ;)

Have you figured out how come the check-jsonschema did not fail when only string is allowed, and it was an array?

It may be a bug, I'll check check-jsonschema and some other validators. I see that rush command is used to install check-jsonschema. I guess it is this one, am I right?

[DannyBen]

I guess it is this one, am I right?

Nope. It is my own rush, and the installation script for check-jsonschema is in my own rush repo.

I simply install it with pipx (on my arch linux).

$ pipx install check-jsonschema

(sorry - just realized I edited your comment instead of replying so I recreated yours.... 🤦)

[EmilyGraceSeville7cf]

It seems to be a bug, I have to investigate why it happens and report about it if developers aren't already informed about it. As a temporary solution, I suggest replacing this validator with another one.

(sorry - just realized I edited your comment instead of replying so I recreated yours.... 🤦)

I thought it was a GitHub bug that it showed your reply and my username above it. 😆

[DannyBen]

So - is this ready to merge from your standpoint?

[EmilyGraceSeville7cf]

So - is this ready to merge from your standpoint?

Yep. I suggest create an issue about this CI problem with check-jsonschema not to forget about it until it fixed.

[DannyBen]

... and one last thing:

It seems to be a bug, I have to investigate why it happens and report

If you know of a better, or the "de facto standard" CLI for validating JSON schema, let me know and I will switch to it.

[DannyBen]

I suggest create an issue about this CI problem with check-jsonschema not to forget about it until it fixed.

Right. I will, once I am also able to create a reproducible simple test case.

[DannyBen]

Thanks for your quick implementation, as always.

[DannyBen]

@EmilyGraceSeville7cf - see #465