Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor environment_variable in schema #476

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Refactor environment_variable in schema #476

merged 1 commit into from
Dec 22, 2023

Conversation

DannyBen
Copy link
Owner

No description provided.

@DannyBen DannyBen changed the title Refactor environment_variable in schema Refactor environment_variable in schema Dec 22, 2023
@DannyBen
Copy link
Owner Author

@EmilyGraceSeville7cf - FYI, I did some changes (in this PR and in 2c75ef0).

Basically I:

  • Removed the "if else" which used to only allow default if required is false. I tried to re-introduce it without code duplication, but failed, so I moved on.
  • Made sure that the environment variable definition appears only once
  • Eliminated all the environment-variables-* properties from the definitions section, and moved them to their natural place (since there is only one occurrence now).

Another reason I removed the if-else (other than the fact that it was hurting my eyes and adding duplicated code), is that there are other places where some values are allowed in some cases, so it felt inconsistent.

This message is FYI, and in case you have some thoughts on the matter.

@DannyBen DannyBen merged commit 7837076 into master Dec 22, 2023
6 checks passed
@DannyBen DannyBen deleted the refactor/schema branch December 22, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant