Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byt soft lockup fixes #575

Draft
wants to merge 9 commits into
base: byt_fsp_parity
Choose a base branch
from
Prev Previous commit
Next Next commit
soc/intel/baytrail/cpu.c: Reflect reference Intel FW settings
Signed-off-by: Michał Żygowski <michal.zygowski@3mdeb.com>
miczyg1 committed Oct 21, 2024
commit 8e481da51ebb828210c071e68fa092150b5aa781
4 changes: 2 additions & 2 deletions src/soc/intel/baytrail/cpu.c
Original file line number Diff line number Diff line change
@@ -50,12 +50,12 @@ unsigned int smbios_processor_family(struct cpuid_result res)
/* Core level MSRs */
static const struct reg_script core_msr_script[] = {
/* Dynamic L2 shrink enable and threshold, clear SINGLE_PCTL bit 11 */
REG_MSR_RMW(MSR_PKG_CST_CONFIG_CONTROL, ~0x3f080f, 0xe0008),
REG_MSR_RMW(MSR_PKG_CST_CONFIG_CONTROL, ~0x3f080f, 0x17000f),
REG_MSR_RMW(MSR_POWER_MISC, ~(ENABLE_ULFM_AUTOCM_MASK | ENABLE_INDP_AUTOCM_MASK), 0),

/* Disable C1E */
REG_MSR_RMW(MSR_POWER_CTL, ~0x2, 0),
REG_MSR_OR(MSR_POWER_MISC, 0x44),
REG_MSR_OR(MSR_POWER_MISC, ENABLE_ULFM_AUTOCM_MASK | ENABLE_IA_UNTRUSTED_MODE),
REG_SCRIPT_END
};

1 change: 1 addition & 0 deletions src/soc/intel/baytrail/include/soc/msr.h
Original file line number Diff line number Diff line change
@@ -10,6 +10,7 @@
#define MSR_POWER_MISC 0x120
#define ENABLE_ULFM_AUTOCM_MASK (1 << 2)
#define ENABLE_INDP_AUTOCM_MASK (1 << 3)
#define ENABLE_IA_UNTRUSTED_MODE (1 << 6)
#define MSR_POWER_CTL 0x1fc
#define MSR_PKG_POWER_SKU_UNIT 0x606
#define MSR_PKG_POWER_LIMIT 0x610