hcl.md: update-hcl-cpu #964
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietrushnic
requested changes
Dec 16, 2024
docs/unified/msi/hcl.md
Outdated
| | 12th Gen Intel(R) Core(TM) i7-12700K | v1.0.0 | [Qubes HCL reports][2] | | ||
| | 12th Gen Intel(R) Core(TM) i7-12700K | v1.0.0 | Dasharo HCL Report | |
There was a problem hiding this comment.
@Stanislaw-bnk, you face these weird, wrong changes because your entries were not sorted. Please note that the line has just moved from two lines above, so there is no change here.
docs/unified/msi/hcl.md
Outdated
| @@ -72,6 +67,7 @@ hardware. | |||
| | 13th Gen Intel(R) Core(TM) i5-13600K | v0.9.0 | Dasharo HCL Report | | |||
| | 13th Gen Intel(R) Core(TM) i5-13600K | v1.1.2 | Dasharo HCL Report | | |||
| | 14th Gen Intel(R) Core(TM) i7-14700K | v0.9.0 | Dasharo HCL Report | | |||
| | Intel(R) Core(TM) i7-14700K | v0.9.0 | Dasharo HCL Report | | |||
There was a problem hiding this comment.
There is something wrong here; there should be a 14th at the beginning for consistency.
docs/unified/msi/hcl.md
Outdated
| | Intel(R) Core(TM) i9-14900K | v0.9.0 | Dasharo HCL Report | | ||
| | Intel(R) Core(TM) i9-14900K | v0.9.1 | Dasharo HCL Report | | ||
| | Intel(R) Core(TM) i9-14900KF | v0.9.0 | Dasharo HCL Report | | ||
| | Intel(R) Core(TM) i9-14900KS | v0.9.1 | Dasharo HCL Report | |
There was a problem hiding this comment.
Lack of 14th at the beginning and a lack of sorting.
|
@pietrushnic fixed all the above in the latest commit: 9c18a93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.