Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort update when no updates available #61

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Conversation

PLangowski
Copy link
Contributor

@PLangowski PLangowski commented Jan 9, 2025

scripts/dasharo-deploy Outdated Show resolved Hide resolved
@PLangowski PLangowski force-pushed the invalid-version-issue branch from 5dcfebe to 320d985 Compare January 9, 2025 14:29
scripts/dasharo-deploy Show resolved Hide resolved
@PLangowski PLangowski requested a review from m-iwanicki January 10, 2025 10:51
Copy link
Contributor

@m-iwanicki m-iwanicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure but your changes don't work on QEMU:

*********************************************************
**                HARDWARE INFORMATION
*********************************************************
**    System Inf.: Micro-Star International Co., Ltd. MS-7D25
** Baseboard Inf.: Micro-Star International Co., Ltd. PRO Z690-A WIFI DDR4(MS-7D25)
**       CPU Inf.:
*********************************************************
**                FIRMWARE INFORMATION
*********************************************************
** BIOS Inf.: 3mdeb Dasharo (coreboot+UEFI) v0.9.0
*********************************************************
**                DPP credentials
*********************************************************
**       Logs key: ***
**   Download key: ***
**       Password: ***
*********************************************************
**     1) Dasharo HCL report
**     2) Update Dasharo Firmware
**     3) Restore firmware from Dasharo HCL report
**     4) Edit your DPP keys
*********************************************************
R to reboot  P to poweroff  S to enter shell
K to launch SSH server  L to enable sending DTS logs
V to enable verbose mode
Enter an option:
2
Gathering flash chip and chipset information...
Flash information: Test Flash Chip
Flash size: 2M
Waiting for network connection ...
Network connection have been established!
Checking if board is Dasharo compatible.
Getting platform specific GPG key... Done
Waiting for system clock to be synced ...
No update available for your machine
Press Enter to continue.

Made sure credentials work:

/public.php/webdav/
/public.php/webdav/MS-7D25/
/public.php/webdav/MS-7D25/v0.9.0/
/public.php/webdav/MS-7D25/v0.9.0/msi_ms7d25_v0.9.0_ddr4_heads.rom
/public.php/webdav/MS-7D25/v0.9.0/msi_ms7d25_v0.9.0_ddr4_heads.rom.sha256
/public.php/webdav/MS-7D25/v0.9.0/msi_ms7d25_v0.9.0_ddr4_heads.rom.sha256.sig
/public.php/webdav/MS-7D25/v0.9.0/msi_ms7d25_v0.9.0_ddr5_heads.rom
/public.php/webdav/MS-7D25/v0.9.0/msi_ms7d25_v0.9.0_ddr5_heads.rom.sha256
/public.php/webdav/MS-7D25/v0.9.0/msi_ms7d25_v0.9.0_ddr5_heads.rom.sha256.sig
/public.php/webdav/MS-7E06/
/public.php/webdav/MS-7E06/v0.9.0/
/public.php/webdav/MS-7E06/v0.9.0/msi_ms7e06_v0.9.0_ddr4_heads.rom
/public.php/webdav/MS-7E06/v0.9.0/msi_ms7e06_v0.9.0_ddr4_heads.rom.sha256
/public.php/webdav/MS-7E06/v0.9.0/msi_ms7e06_v0.9.0_ddr4_heads.rom.sha256.sig
/public.php/webdav/MS-7E06/v0.9.0/msi_ms7e06_v0.9.0_ddr5_heads.rom
/public.php/webdav/MS-7E06/v0.9.0/msi_ms7e06_v0.9.0_ddr5_heads.rom.sha256
/public.php/webdav/MS-7E06/v0.9.0/msi_ms7e06_v0.9.0_ddr5_heads.rom.sha256.sig

include/dts-functions.sh Outdated Show resolved Hide resolved
scripts/dasharo-deploy Show resolved Hide resolved
@m-iwanicki
Copy link
Contributor

@PLangowski nvm about it not working, I forgot to pull newest changes

@PLangowski PLangowski force-pushed the invalid-version-issue branch 2 times, most recently from 5ba2909 to 983f6bf Compare January 10, 2025 11:59
@PLangowski PLangowski requested a review from m-iwanicki January 10, 2025 12:06
@m-iwanicki
Copy link
Contributor

@PLangowski what about #61 (comment)? Or it's different issue?

@PLangowski PLangowski force-pushed the invalid-version-issue branch from 983f6bf to 98ad3a9 Compare January 10, 2025 13:21
@PLangowski PLangowski force-pushed the invalid-version-issue branch from 98ad3a9 to 4ab58c4 Compare January 10, 2025 13:49
@PLangowski PLangowski merged commit e69c7e0 into main Jan 10, 2025
1 check passed
@PLangowski PLangowski deleted the invalid-version-issue branch January 10, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ERROR Invalid version '' error in DTS on MS-7E06 when trying to update
3 participants