Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DasharoPayloadPkg/PlatformBootManagerLib: Add missing BlParseLib in the INF file #156

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

miczyg1
Copy link
Contributor

@miczyg1 miczyg1 commented Jul 25, 2024

Fix build complaining on missing ParseVBootWorkbuf.

@krystian-hebel
Copy link
Contributor

I don't see this complaint on Q35 with vboot enabled (I had to modify .fmd file for SMMSTORE and RO_FRID/RW_FWID_A sizes). How can I replicate the issue?

@miczyg1
Copy link
Contributor Author

miczyg1 commented Aug 2, 2024

I don't see this complaint on Q35 with vboot enabled (I had to modify .fmd file for SMMSTORE and RO_FRID/RW_FWID_A sizes). How can I replicate the issue?

I couldn't build the firmware for MinnowBoard Turbot here, that's how it started.

@miczyg1
Copy link
Contributor Author

miczyg1 commented Aug 6, 2024

@SergiiDmytruk if I am not mistaken, the PlatformBootManagerLib uses BlParseLib: https://github.com/Dasharo/edk2/blob/rebased/DasharoPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c#L16
ParseVBootWorkbuf is clearly a part of CbParseLib: https://github.com/Dasharo/edk2/blob/rebased/DasharoPayloadPkg/Library/CbParseLib/CbParseLib.c#L881

So my change should be correct. But I have no idea why all other platforms actually build, while MinnowMax not: https://github.com/Dasharo/coreboot/actions/runs/10264908984?pr=542

@miczyg1 miczyg1 requested a review from SergiiDmytruk August 6, 2024 10:51
Copy link
Member

@SergiiDmytruk SergiiDmytruk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I have no idea why all other platforms actually build, while MinnowMax not

I don't think the build system enforces declarations in a strict way. As long as something (directly or indirectly) used by a particular DXE mentions BlParseLib in its .inf-file, the DXE gets the library and there will be no error if you use it without a declaration. The EDK2 configuration of MinnowMax probably results in BlParseLib not being mentioned at all in the dependency graph of BdsDxe, thus causing the error.

I saw the same happening with GUIDs: Dasharo/edk2-upstream@357a7d5

…he INF file

Fix build complaining on missing ParseVBootWorkbuf.

Signed-off-by: Michał Żygowski <[email protected]>
@miczyg1 miczyg1 force-pushed the fix_missing_blparselib branch from f6f62e8 to 26f855c Compare August 6, 2024 22:27
@miczyg1 miczyg1 merged commit 26f855c into rebased Aug 6, 2024
1 check passed
@miczyg1 miczyg1 deleted the fix_missing_blparselib branch August 6, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants